fix(dtslint): disable tests that break in TS@next #4705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, there is no way to stop dtslint from testing in TS@next. RxJS 6 targets TS 2.8, and there is no `unknown` type. We'll need to uncomment these and correct types in v 7 when we updated to TS latest.
kwonoj
approved these changes
Apr 10, 2019
kwonoj
approved these changes
Apr 10, 2019
Pull Request Test Coverage Report for Build 8342
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, there is no way to stop dtslint from testing in TS@next. RxJS 6 targets TS 2.8, and there is no
unknowntype. We'll need to uncomment these and correct types in v 7 when we updated to TS latest.